From: Abderrahim Kitouni Date: Tue, 30 Nov 2010 15:12:22 +0000 (+0100) Subject: Fix ripple animation for RTL locales X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~8525 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=12fad6f05f7b2183317dd35db95d479c8e44f5f5;p=gnome-shell.git Fix ripple animation for RTL locales The animation was invisible because it was going out of screen, also add a mirrored version of the image to the theme. https://bugzilla.gnome.org/show_bug.cgi?id=584662 --- diff --git a/data/Makefile.am b/data/Makefile.am index b0477194c..819b15c34 100644 --- a/data/Makefile.am +++ b/data/Makefile.am @@ -24,7 +24,8 @@ dist_theme_DATA = \ theme/calendar-today.svg \ theme/close-window.svg \ theme/close.svg \ - theme/corner-ripple.png \ + theme/corner-ripple-ltr.png \ + theme/corner-ripple-rtl.png \ theme/dash-placeholder.svg \ theme/filter-selected-ltr.svg \ theme/filter-selected-rtl.svg \ diff --git a/data/theme/corner-ripple-ltr.png b/data/theme/corner-ripple-ltr.png new file mode 100644 index 000000000..326ecaa52 Binary files /dev/null and b/data/theme/corner-ripple-ltr.png differ diff --git a/data/theme/corner-ripple-rtl.png b/data/theme/corner-ripple-rtl.png new file mode 100644 index 000000000..26cf965f6 Binary files /dev/null and b/data/theme/corner-ripple-rtl.png differ diff --git a/data/theme/corner-ripple.png b/data/theme/corner-ripple.png deleted file mode 100644 index 326ecaa52..000000000 Binary files a/data/theme/corner-ripple.png and /dev/null differ diff --git a/data/theme/gnome-shell.css b/data/theme/gnome-shell.css index e26c16249..caaa5c425 100644 --- a/data/theme/gnome-shell.css +++ b/data/theme/gnome-shell.css @@ -1280,7 +1280,11 @@ StTooltip StLabel { .ripple-box { width: 52px; height: 52px; - background-image: url("corner-ripple.png"); + background-image: url("corner-ripple-ltr.png"); +} + +.ripple-box:rtl { + background-image: url("corner-ripple-rtl.png"); } .switcher-arrow { diff --git a/js/ui/panel.js b/js/ui/panel.js index 5ef212a93..8cbceb051 100644 --- a/js/ui/panel.js +++ b/js/ui/panel.js @@ -706,6 +706,8 @@ HotCorner.prototype = { x: x, y: y }); ripple._opacity = startOpacity; + if (ripple.get_direction() == St.TextDirection.RTL) + ripple.set_anchor_point_from_gravity(Clutter.Gravity.NORTH_EAST); Tweener.addTween(ripple, { _opacity: finalOpacity, scale_x: finalScale, scale_y: finalScale,